Skip to content

Support differentiation of wrapped value modify accessors #78794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Support differentiation of wrapped value modify accessors #78794

wants to merge 4 commits into from

Conversation

asl
Copy link
Contributor

@asl asl commented Jan 21, 2025

Some fixes for coroutines with normal results and partial_apply of coroutines were required.

Fixes #55084

@asl asl requested a review from rxwei January 21, 2025 20:49
@asl
Copy link
Contributor Author

asl commented Jan 21, 2025

@swift-ci please test

@asl
Copy link
Contributor Author

asl commented Jan 21, 2025

Tagging @JaapWijnen

@asl asl added the AutoDiff label Jan 21, 2025
@asl
Copy link
Contributor Author

asl commented Jan 21, 2025 •
edited
Loading

The addition of derivative to Tracked<T>.*= is trivial: the operator is marked as @differentiable but no custom derivative was specified. It does not influence ABI as it is a part of DifferentiableUnittests module

@asl
Copy link
Contributor Author

asl commented Jan 24, 2025

@swift-ci please test linux

@asl asl force-pushed the diff-modify-property-wrappers branch from c675009 to b4a8fc0 Compare April 2, 2025 06:18
@asl
Copy link
Contributor Author

asl commented Apr 2, 2025

@swift-ci please test

@asl
Copy link
Contributor Author

asl commented Apr 7, 2025

ping

@JaapWijnen
Copy link
Contributor

This is a prerequisite to the PR enabling custom derivatives from _modify accessors right @asl ? (#78508)

@asl
Copy link
Contributor Author

asl commented May 12, 2025

This is a prerequisite to the PR enabling custom derivatives from _modify accessors right @asl ? (#78508)

It contains common codegen fixes. So I would like to have them committed first and separately to reduce amount of changes in #78508

@asl
Copy link
Contributor Author

asl commented May 19, 2025 •
edited
Loading

@swiftlang/standard-librarians Are you ok with stdlib changes? They are internal as only add couple of missed derivatives to stdlib/private/DifferentiationUnittest/DifferentiationUnittest.swift.gyb

@asl
Copy link
Contributor Author

asl commented May 19, 2025

@rjmccall Will you please review irgen changes? They are essentially ensures that coroutine return value is lowered in the proper generic context. See 7b2fecc

@asl asl force-pushed the diff-modify-property-wrappers branch from b4a8fc0 to 63ab094 Compare May 19, 2025 11:28
@asl
Copy link
Contributor Author

asl commented May 19, 2025

@swift-ci please test

@asl asl force-pushed the diff-modify-property-wrappers branch from 63ab094 to 6fac043 Compare July 11, 2025 16:33
@asl asl removed the request for review from a team July 11, 2025 16:33
@asl
Copy link
Contributor Author

asl commented Jul 11, 2025

@swift-ci please test

@asl
Copy link
Contributor Author

asl commented Jul 11, 2025

@rjmccall another friendly ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaapWijnen JaapWijnen JaapWijnen left review comments

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@hborla hborla Awaiting requested review from hborla

@slavapestov slavapestov Awaiting requested review from slavapestov

@xedin xedin Awaiting requested review from xedin

@rxwei rxwei Awaiting requested review from rxwei

Assignees
No one assigned
Labels
AutoDiff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SR-12640] Differentiation transform: support wrapped value modify accessors
2 participants
@asl @JaapWijnen